Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade min Bazel required and upgrade CI to use 2.1 #3239

Merged
merged 2 commits into from
Apr 21, 2020
Merged

Upgrade min Bazel required and upgrade CI to use 2.1 #3239

merged 2 commits into from
Apr 21, 2020

Conversation

stephanwlee
Copy link
Contributor

@stephanwlee stephanwlee commented Feb 12, 2020 •
edited
Loading

Bazel is now out of the beta mode (version 0.x). We want to depend on
1+ for better long term support in the future.

@stephanwlee stephanwlee force-pushed the bazel_up branch 2 times, most recently from d198845 to cac4926 Compare February 27, 2020 00:33
@stephanwlee stephanwlee marked this pull request as ready for review February 27, 2020 16:18
@bileschi bileschi requested a review from nfelt March 18, 2020 20:18
nfelt
nfelt approved these changes Mar 18, 2020
View reviewed changes
Copy link
Contributor

@nfelt nfelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like there was some reason we'd been unsure if we wanted to do this, but I can't remember and maybe it was just my oversight - at any rate, LGTM.

@stephanwlee
Copy link
Contributor Author

This is the reason:
image

49m is too tight for our comfort and I wasn't sure if we should pursue this route. It just has to miraculously pass only once for cache to prolong our life with Travis but that's... not cool.

@nfelt nfelt mentioned this pull request Apr 15, 2020
Closed
@stephanwlee stephanwlee merged commit 6ab1d00 into tensorflow:master Apr 21, 2020
@stephanwlee stephanwlee deleted the bazel_up branch April 21, 2020 00:30
@nfelt
Copy link
Contributor

nfelt commented Apr 21, 2020

💥 💥 💥

caisq pushed a commit to caisq/tensorboard that referenced this pull request May 19, 2020
@stephanwlee @caisq
Upgrade min Bazel required and upgrade CI to use 2.1 (tensorflow#3239)
887c5e8 
Bazel is now out of the beta mode (version 0.x). We want to depend on
1+ for better long term support in the future.
caisq pushed a commit that referenced this pull request May 27, 2020
@stephanwlee @caisq
Upgrade min Bazel required and upgrade CI to use 2.1 (#3239)
2f49d59 
Bazel is now out of the beta mode (version 0.x). We want to depend on
1+ for better long term support in the future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfelt nfelt nfelt approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephanwlee @nfelt @googlebot